|
With the real issue identified (panorama geometry fitted rectinearly:
provably unsatisfiable marker sets) the pieces added while chasing it
were re-evaluated against a 543-placement sweep of VALID geometries
(straddle + same-side pairs, north crossings, pitch/roll spread,
marker noise, cylindrical wide pairs):
- center seeds: the six-way full-circle spread is unnecessary; the
placement roulette it was built against was the degenerate cost ties
(fixed by the validity filter) and the panorama phantom. A single
derived center seed passes all 543 valid placements. The principled
scale (linear + tangent-aware) and pitch seeds stay: 4 fits total.
- final domain guard: redundant. The validity filter already enforces
the same condition before a candidate can be chosen; the fallback
path is caught by the RMS guard with a better message.
- the sweep itself is promoted to tests/fit_sweep.rs as the permanent
regression net for the seed/validity logic.
Kept (each fixes a real, independent bug): repaint + refit on
projection switch, validity-filtered candidate selection, marker order
check, same-side feasibility pre-check with panorama hint, RMS guard,
fit session logging (the instrument that found the issue).
43 core + 13 golden + 543-placement sweep green, clippy clean.
|