From f0cf0c3e95ca0518de754f7915458bd90e8abf32 Mon Sep 17 00:00:00 2001 From: Johannes Hofmann Date: Wed, 28 Oct 2026 09:23:55 +0100 Subject: core: guard atof prefix slicing against char boundaries The longest-numeric-prefix fallback sliced s[..i] at every byte index, which panics when i lands inside a multi-byte character (reachable via lossy-decoded Latin-1 database fields, e.g. a trailing degree sign). Skip non-boundary indices; behavior on ASCII numeric fields is unchanged. Includes regression test atof("12.5 deg"). --- crates/gipfel-core/src/hill.rs | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'crates/gipfel-core/src/hill.rs') diff --git a/crates/gipfel-core/src/hill.rs b/crates/gipfel-core/src/hill.rs index 4ae0f89..254a9e4 100644 --- a/crates/gipfel-core/src/hill.rs +++ b/crates/gipfel-core/src/hill.rs @@ -67,6 +67,9 @@ fn atof(s: &str) -> f64 { return v; } for i in (1..s.len()).rev() { + if !s.is_char_boundary(i) { + continue; + } if let Ok(v) = s[..i].parse::() { return v; } @@ -163,6 +166,8 @@ mod tests { assert_eq!(atof("abc"), 0.0); assert_eq!(atof("12abc"), 12.0); assert_eq!(atof(" -3.5x"), -3.5); + // prefix cut must not slice through a multi-byte character + assert_eq!(atof("12.5\u{b0}"), 12.5); } #[test] -- cgit v1.2.3