summaryrefslogtreecommitdiff
path: root/crates/gipfel-core/src
diff options
context:
space:
mode:
authorJohannes Hofmann <Johannes.Hofmann@gmx.de>2026-10-28 09:23:55 +0100
committerJohannes Hofmann <Johannes.Hofmann@gmx.de>2026-10-28 10:34:53 +0100
commitf0cf0c3e95ca0518de754f7915458bd90e8abf32 (patch)
treebbc1020e198487bef95d2cd07e10e92f03690ccd /crates/gipfel-core/src
parent11689fb14f3a4d0291e2ccc05d6cb3556e4ea1ab (diff)
core: guard atof prefix slicing against char boundaries
The longest-numeric-prefix fallback sliced s[..i] at every byte index, which panics when i lands inside a multi-byte character (reachable via lossy-decoded Latin-1 database fields, e.g. a trailing degree sign). Skip non-boundary indices; behavior on ASCII numeric fields is unchanged. Includes regression test atof("12.5 deg").
Diffstat (limited to 'crates/gipfel-core/src')
-rw-r--r--crates/gipfel-core/src/hill.rs5
1 files changed, 5 insertions, 0 deletions
diff --git a/crates/gipfel-core/src/hill.rs b/crates/gipfel-core/src/hill.rs
index 4ae0f89..254a9e4 100644
--- a/crates/gipfel-core/src/hill.rs
+++ b/crates/gipfel-core/src/hill.rs
@@ -67,6 +67,9 @@ fn atof(s: &str) -> f64 {
return v;
}
for i in (1..s.len()).rev() {
+ if !s.is_char_boundary(i) {
+ continue;
+ }
if let Ok(v) = s[..i].parse::<f64>() {
return v;
}
@@ -163,6 +166,8 @@ mod tests {
assert_eq!(atof("abc"), 0.0);
assert_eq!(atof("12abc"), 12.0);
assert_eq!(atof(" -3.5x"), -3.5);
+ // prefix cut must not slice through a multi-byte character
+ assert_eq!(atof("12.5\u{b0}"), 12.5);
}
#[test]